BUG: raise a proper exception when str.rsplit is passed a regex and clarify the docs #62035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 4, 2025
Comment on lines
+946
to
+948
| if pat is not None and not isinstance(pat, str): | ||
| msg = f"expected a string object, not {type(pat).__name__}" | ||
| raise TypeError(msg) |
There was a problem hiding this comment.
Can you put this in _str_rsplit for each implementation?
There was a problem hiding this comment.
Sure no problem but this exact error is raised here for the other methods so I was following the same process. See for example find.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Noticed this while working on pandas-dev/pandas-stubs#1278.
rsplitdoesn't accept regular expressions but was silently accepting them and producing bad results. I added a check on the type of the input and updated the documentation.